Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery Coremod #611

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Conversation

zrodevkaan
Copy link
Contributor

uhhh yeah something something lint fix and recovery.

DO NOT MERGE YET
Specifically made this pr for reviewing types.

@zrodevkaan zrodevkaan changed the title uhhhh. something something Recovery Coremod Apr 4, 2024
@12944qwerty 12944qwerty marked this pull request as draft April 4, 2024 01:04
@zrodevkaan zrodevkaan marked this pull request as ready for review April 4, 2024 02:27
src/renderer/coremods/recovery/index.tsx Show resolved Hide resolved
src/renderer/coremods/recovery/index.tsx Outdated Show resolved Hide resolved
src/renderer/coremods/recovery/index.tsx Outdated Show resolved Hide resolved
src/renderer/coremods/recovery/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@12944qwerty 12944qwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cspell.json Outdated Show resolved Hide resolved
startMainRecovery();
instance.setState({ error: null, info: null });
}}>
Recover Discord
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n missing here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what to do here as I removed the other i18n string due to you saying you dont know what would happen with conflicts

}

export async function startErrors(): Promise<void> {
ReactErrors = await fetch(ReactErrorList).then((response) => response.json());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also handle in case the fetch fails for some reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now what should this fallback be.

src/renderer/coremods/recovery/styles.css Outdated Show resolved Hide resolved
src/renderer/coremods/recovery/index.tsx Show resolved Hide resolved
src/renderer/coremods/recovery/index.tsx Outdated Show resolved Hide resolved
i18n/en-US.json Outdated Show resolved Hide resolved
src/renderer/coremods/recovery/index.tsx Outdated Show resolved Hide resolved
@zrodevkaan zrodevkaan requested a review from FedeIlLeone April 10, 2024 20:32
@FedeIlLeone FedeIlLeone added enhancement New feature or request semver: minor Requires a minor semver version bump labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver: minor Requires a minor semver version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants